Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat not working after transcript announce message recieved #1997

Closed
HighwayStar opened this issue Jan 15, 2025 · 8 comments · Fixed by jitsi/jitsi-meet#15492
Closed

Chat not working after transcript announce message recieved #1997

HighwayStar opened this issue Jan 15, 2025 · 8 comments · Fixed by jitsi/jitsi-meet#15492

Comments

@HighwayStar
Copy link

HighwayStar commented Jan 15, 2025

I'm using docker installation of jitsi stable-9955 with vosk transcription, JIGASI_TRANSCRIBER_ADVERTISE_URL=true

Faced strange issue:

When conference created and users connected thay could use chat wihout issue, but when moderator enables Subtitles and Announcement message appeared in chat it became broken. Users who post messages in chat cannot see its own messages, while moderator can see it.

Chat became broken on clients after such error in js console

JingleSessionPC.js:417 2025-01-15T09:30:33.281Z [modules/xmpp/JingleSessionPC.js] JingleSessionPC[session=JVB,initiator=false,sid=52tsmmrc1ls7v] addRemoteStream - OK
strophe.util.js:84 2025-01-15T09:31:03.555Z [modules/xmpp/strophe.util.js] <Dl.Ii.Strophe.log>:  Strophe: TypeError: Cannot read properties of undefined (reading 'replace')
    at C9 (https://meet.x.x/libs/app.bundle.min.js?v=8339:85:354668)
    at https://meet.x.x/libs/app.bundle.min.js?v=8339:85:359225

Full js log attached.

meet-1736933516132.log

@HighwayStar
Copy link
Author

And seems it happens only on chrome based browsers, when Firefox clients have chat working

@HighwayStar
Copy link
Author

did some tests, looks more like chat stops working on first subtitle message recieved. If I starting transcribtion with switched off mics chat works until mic enabled and subtitle message sent.

@HighwayStar
Copy link
Author

I did some js debugging, and it seem

 const language = state['features/base/conference'].conference
        ?.getLocalParticipantProperty(P_NAME_TRANSLATION_LANGUAGE);

in middleware.js function _endpointMessageReceived(store, next, action) result is undefined, and next it crashes in _getPrimaryLanguageCode()

@HighwayStar
Copy link
Author

I've tried to lunch minimal eaxample, here is my env file attached.

test.txt

starting like

sudo docker compose -f docker-compose.yml -f jigasi.yml -f transcriber.yml up

vosk container running on separate machine

I also checked with previous release 9909 and here chrome working fine, but Firefox was broken. Will try one older.

@saghul
Copy link
Member

saghul commented Jan 16, 2025

Thanks for digging all the way down!

saghul added a commit to saghul/jitsi-meet that referenced this issue Jan 16, 2025
If we are not requesting any transcription, `language` will be `null` so
take that into consideration when checking if we should stop processing
a transcription message after firing the API event.

Fixes: jitsi/docker-jitsi-meet#1997
@saghul
Copy link
Member

saghul commented Jan 16, 2025

Fix: #1997

@HighwayStar
Copy link
Author

Now works fine, thank you for fix.

@saghul
Copy link
Member

saghul commented Jan 17, 2025

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants