feat(transcriber): fix exposing transcript path in web #1955
Conversation
This addes the transcipts path to the list of static items that should be allowed by nginx. Fixes jitsi#1427 Signed-off-by: Ben Magistro <koncept1@gmail.com>
|
Have you tested this? I don't think ti would work since the web container is not where the transcript files are stored, are they? |
|
Very valid question as I expected it to be more complicated too. I did and have it running on a test instance right now. Looking now at the why/how, it looks like transcripts are volume mounted in via the web compose https://github.com/jitsi/docker-jitsi-meet/blob/master/docker-compose.yml#L14C1-L15C1 . I didn't look to see why when developing this, just exec'd in and started looking around based on the logs but also knew our compose files should be pretty close to the stock ones provided. |
|
Ah looks like we have them mounted here: docker-jitsi-meet/transcriber.yml Line 9 in 74d913f LGTM @aaronkvanmeerten any objections? |
This addes the transcipts path to the list of static items that should be allowed by nginx.
Fixes #1427