feat: Adds notification for conference audio recordings. #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrozev
reviewed
Oct 28, 2024
|
|
||
| if (rs != null) | ||
| { | ||
| notifyRecordingStatusChanged(rs.getRecordingMode(), rs.getStatus()); |
There was a problem hiding this comment.
I think this will result in playing "recording is off" when both jibri and audio recording are on and the jibri is stopped. I think we should read the recording state from both the jibri extension and ConferenceProperties together, and then act on it.
bgrozev
reviewed
Oct 28, 2024
| notifyRecordingStatusChanged(rs.getRecordingMode(), rs.getStatus()); | ||
|
|
||
| return; | ||
| isJibriRecordingOn = true; |
There was a problem hiding this comment.
This is incorrect when there is a RecordingStatus extension with status=OFF
bgrozev
reviewed
Nov 4, 2024
src/main/java/org/jitsi/jigasi/sounds/SoundNotificationManager.java
Outdated
Show resolved
Hide resolved
…nManager.java Co-authored-by: bgrozev <boris@jitsi.org>
bgrozev
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jitsi/jitsi-xmpp-extensions#109