Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChatRoom) refactor handling of participant properties #2588

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(ChatRoom) refactor handling of participant properties #2588

merged 2 commits into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. fix(ChatRoom) refactor handling of participant properties 

    Avoid duplicates.
    @saghul
    saghul committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1b83091 View commit details
    Browse the repository at this point in the history

  2. feat(JitsiParticipant) use a Map for properties, rather than an object 

    See https://www.zhenghao.io/posts/object-vs-map

Since these objects will change with reasonable requency, we'll create
many shapes and consume more memory than a Map.
    @saghul
    saghul committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    01abc38 View commit details
    Browse the repository at this point in the history