Remove response.data.status check #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's perfectly valid for a head to be "behind" a base when comparing commits for pull request events. For example, PRing a feature branch of `main` while other commits have landed on `main` after the feature branch was started but before the PR was created, or a PR to merge a "development" branch onto a slower moving "release" branch that has some hotfixes on it.
3 tasks
Ana06
added a commit
to Ana06/get-changed-files
that referenced
this pull request
Jun 4, 2021
I have cherry-picked the removal of the ahead check: jitterbit#25 This seems to be a change Jitterbit's community agrees on: jitterbit#17 Build this change and prepare v1.2 release.
|
Nice change @sargunv! I have cherry-picked 54f3703 and released it in Ana06/get-changed-files@v1.2 because we want to use it in capa. But this seems to be a change that the community want: #11, #19, so I hope this makes it upstream. In case it doesn't (or until it does), feel free to use Ana06/get-changed-files@v1.2 (which also supports |
|
Any progress on this one? |
|
Seems like this isn't merging, closing to clear my queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's perfectly valid for a head to be "behind" a base when comparing commits for pull request events. For example, PRing a feature branch of
mainwhile other commits have landed onmainafter the feature branch was started but before the PR was created, or a PR to merge a "development" branch onto a slower moving "release" branch that has some hotfixes on it.