Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY3: changes not suggested by pyupgrade #179

Merged
merged 1 commit into from
Dec 6, 2022
Merged

PY3: changes not suggested by pyupgrade #179

merged 1 commit into from
Dec 6, 2022

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@jjhelmus
Copy link
Owner

jjhelmus commented Dec 6, 2022

LGTM

@jjhelmus jjhelmus merged commit 7c697cb into jjhelmus:master Dec 6, 2022
@kaustubhmote
Copy link
Collaborator

This merge may need to be partially reverted. xcpy module works within Topspin with Jython rather than CPython, which is why the antiquated style/features of Python 2.7 is used everywhere.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Dec 7, 2022

I just discovered that Jython only supports Python 2. Given the pace of change of Python libraries, I guess this means Jython is more or less dead. Any way, since the xcpy module works within TopSpin which includes Jython, there is no discussion here: I will revert xcpy.py and xcpy_test.py changes. Sorry about the mess.

@DimitriPapadopoulos
Copy link
Contributor Author

BTW, I got confused by setup.py:

        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: 3.7',
        'Programming Language :: Python :: 3.8',
        'Programming Language :: Python :: 3.9',

@DimitriPapadopoulos
Copy link
Contributor Author

Reverted in #183.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants