Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button size changes with rotation/transition #191

Closed
jjochen opened this issue Feb 4, 2019 · 3 comments
Closed

Button size changes with rotation/transition #191

jjochen opened this issue Feb 4, 2019 · 3 comments
Labels
bug
Milestone
1.2.0

Comments

@jjochen
Copy link
Owner

jjochen commented Feb 4, 2019

When the target image (including rotated image) is bigger then the button diameter the size of the button increases when opened.
@jjochen jjochen added the bug label Feb 4, 2019
@jjochen jjochen added this to the 1.2.0 milestone Feb 4, 2019
@jjochen jjochen mentioned this issue Feb 4, 2019
Merged
@jjochen
Copy link
Owner Author

jjochen commented Feb 4, 2019

For now the safest way is to define the size of the button with autolayout.

actionButton.translatesAutoresizingMaskIntoConstraints = false
actionButton.widthAnchor.constraint(equalToConstant: 65).isActive = true
actionButton.heightAnchor.constraint(equalToConstant: 65).isActive = true

@wdcurry
Copy link

wdcurry commented Feb 4, 2019

dude, you are definitely "on it"! thank you. Awesome focused repo.

@MarcSteven
Copy link

For now the safest way is to define the size of the button with autolayout.

actionButton.translatesAutoresizingMaskIntoConstraints = false
actionButton.widthAnchor.constraint(equalToConstant: 65).isActive = true
actionButton.heightAnchor.constraint(equalToConstant: 65).isActive = true

Yeah it makes sense ,give the actionButton the constraints(Width and height)))

@jjochen jjochen mentioned this issue Feb 8, 2019
Merged
jjochen added a commit that referenced this issue Feb 8, 2019
@jjochen
Prevent images to change button/item size (#193)
7477205 
Images are now subviews of the circle background view. 
Like that we can set the define hugging and content compression resistance priorities.

Fixes #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@jjochen @wdcurry @MarcSteven