Support different signals than SIGKILL

[hiddewie]

The kill command supports the command-line option to specify the signal sent to the killed processes.

https://www.man7.org/linux/man-pages/man1/kill.1.html, the option --signal.

Sending other signals than SIGKILL can be useful to reload the process listening on a certain port (like nginx), or gracefully shutdown a service, or invoke other user-defined functionality.

Relevant code:

killport/src/linux.rs

Line 176 in 3a43d03

kill(pid, Signal::SIGKILL).map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))

[NachiketNamjoshi]

I can pick this up. @jkfran lmk if you have any issues/ideas on this.

[jkfran]

@NachiketNamjoshi, Thank you so much! My only suggestion is to keep using clap to parse this new argument. Apart from that, you are welcome to be creative 😄

[0kate]

@jkfran I have added some changes for additional options to specify different signal types! (SIGTERM and SIGKILL only now)
I would appreciate it if you could check a PR below 🙏
#13

[0kate]

@jkfran
Thank you review and merging PR above! Could I continue to add support for other signal types?

[jkfran]

@jkfran Thank you review and merging PR above! Could I continue to add support for other signal types?

I think Sigterm and Sigkill are enough for killport. Let's see if we get requests about supporting the other signals. Feel free to contribute to any of the other issues.

[jkfran]

This issue was solved on #13

Killport will now use sigterm by default and it is possible to use sigkill by using -s or --signal.

Thank you so much @0kate for contributing to this project.