Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composer-locator #69

Merged
merged 1 commit into from
May 16, 2022

Conversation

jspaetzel
Copy link
Contributor

@jspaetzel jspaetzel commented May 14, 2022

Because this contains a plugin it prompts on every composer execution,

mindplay/composer-locator contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "mindplay/composer-locator" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?]

rather than enable the plugin, why not just remove this since it's so sparsely used?

I've also bundled in a "minimum-stability": "dev" change here because I don't see any reason why this would need a minimum stability of dev. Old artifact maybe?

@rvanlaak rvanlaak merged commit e2f8411 into jkphl:master May 16, 2022
@rvanlaak
Copy link
Collaborator

As long as tests pass there is no need for minimum stability, as this is a Composer root tag (so only applies on the root level of a project requiring this package).

Thanks for the PR!

@jspaetzel jspaetzel deleted the remove_composer_locator_dep branch May 16, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants