Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL: fix downloader plugin #482

Merged
merged 2 commits into from
Nov 4, 2024
Merged

WSL: fix downloader plugin #482

merged 2 commits into from
Nov 4, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it: Fix downloader plugin, if helm is installed as native binary inside WSL

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #477

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Fix downloader plugin, if helm is installed as native binary inside WSL

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Repository owner deleted a comment from github-actions bot Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (d1b66f7) to head (839d3be).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
scripts/lib/common.sh 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   87.33%   87.42%   +0.08%     
==========================================
  Files          22       22              
  Lines         845      843       -2     
==========================================
- Hits          738      737       -1     
+ Misses        107      106       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke jkroepke merged commit e3e45f5 into main Nov 4, 2024
15 checks passed
@jkroepke jkroepke deleted the fix-wsl branch November 4, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol handler from terminal
1 participant