Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Vault driver does not abort on error #61

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Fix: Vault driver does not abort on error #61

merged 4 commits into from
Dec 16, 2020

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Dec 16, 2020 •
edited
Loading

Fixes #60

while runs inside a sub shell, the exit 1 from the while loop should be passed to the main loop

@jkroepke jkroepke force-pushed the vault-fail-on-error branch 3 times, most recently from d6ae7c7 to 14dd4c9 Compare December 16, 2020 13:34
@jkroepke jkroepke changed the title Added tests for vault failure Fix: Vault driver does not abort on error Dec 16, 2020
@jkroepke jkroepke merged commit fedf0c8 into master Dec 16, 2020
@jkroepke jkroepke deleted the vault-fail-on-error branch December 16, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vault driver does not abort on error
1 participant
@jkroepke