Targets management version 4 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redesign targets management once more: * Users still make target content changes (outside of the tool) * Let repository do the actual metadata changes during signing-event (the method is called status() but signing_event_update() might be better) * Repository also documents the target changes at high level in the signing event * Users sign normally: "playground-sign <EVENT>" This makes the UX much more neat and does not complicate the repository too much. The expected targets metadata change in e2e tests is because the PlaygroundRepository does not figure out version numbers as smartly as SignerRepository does, and ends up bumping versions more than needed: this could be fixed but it's not critical targets metadata. This change means "playground-status" now makes commits and pushes them to signing event branch. This means the commands name is now not very descriptive. Changing it should not be disruptive but I did not want to grow this PR, so leaving that for later.
|
Overall looks good! Especially the transfer of |
Agreed, Thanks, I'll merge this (with some added some linting fixes straight from running "black") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign targets management once more:
This makes the UX cleaner and does not complicate the repository too much.
The expected targets metadata change in e2e tests is because the PlaygroundRepository does not figure out version numbers as smartly as SignerRepository does, and ends up bumping versions more than needed: this could be fixed but it's not critical targets metadata.
This change means "playground-status" now makes commits and pushes them to signing event branch. This means the commands name is now not very descriptive. Changing it should not be disruptive but I did not want to grow this PR, so leaving that for later.