-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "container" option of clipboardJS #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkusa sure, no prob. :) |
README.md
Outdated
@@ -60,6 +60,7 @@ http://jkusa.github.io/ember-cli-clipboard | |||
- `clipboardText` - string value or action that returns a string to be copied | |||
- `clipboardTarget` - selector string of element from which to copy text | |||
- `clipboardAction` - string value of operation: `copy` or `cut` (default is copy) | |||
- `container` - selector string of element, or element, containing the component. If you want to use the component inside a modal, this property is mandatory and should referred to the modal element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `container` - selector string of element, or element, containing the component. If you want to use the component inside a modal, this property is mandatory and should referred to the modal element. | |
- `container` - selector string or element object of containing element. "For use in Bootstrap Modals or with any other library that changes the focus you'll want to set the focused element as the container value". |
@enna change look good. Just a small tweak to the readme and we should be good. |
All should be good now @jkusa :) |
We could really use this improvement! Any plan on cutting an NPM release with container support @jkusa? |
This PR handles the
container
option of ClipboardJS, as described here.Thiscontainer
option allows the clipboard to work in modals, which will fix issue #180