Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember 3.21 #252

Merged
merged 1 commit into from
Sep 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ module.exports = {
env: {
browser: true,
},
rules: {
'ember/no-jquery': 'error',
},
rules: {},
overrides: [
// node files
{
Expand Down Expand Up @@ -46,13 +44,7 @@ module.exports = {
node: true,
},
plugins: ['node'],
rules: Object.assign(
{},
require('eslint-plugin-node').configs.recommended.rules,
{
// add your custom rules and overrides for node files here
}
),
},
],
extends: ['plugin:node/recommended']
}
]
};
7 changes: 2 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ node_js:
# so that your addon works for all apps
- '10'

dist: trusty
dist: xenial

addons:
chrome: stable
Expand Down Expand Up @@ -50,8 +50,8 @@ jobs:

# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- env: EMBER_TRY_SCENARIO=ember-lts-3.12
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
- env: EMBER_TRY_SCENARIO=ember-lts-3.20
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary
Expand All @@ -62,8 +62,5 @@ before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH=$HOME/.yarn/bin:$PATH

install:
- yarn install --no-lockfile --non-interactive

script:
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO
32 changes: 11 additions & 21 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ module.exports = async function () {
useYarn: true,
scenarios: [
{
name: 'ember-lts-3.12',
name: 'ember-lts-3.16',
npm: {
devDependencies: {
'ember-source': '~3.12.0',
},
},
'ember-source': '~3.16.0'
}
}
},
{
name: 'ember-lts-3.16',
name: 'ember-lts-3.20',
npm: {
devDependencies: {
'ember-source': '~3.16.0',
},
},
'ember-source': '~3.20.5'
}
}
},
{
name: 'ember-release',
Expand All @@ -46,16 +46,6 @@ module.exports = async function () {
},
},
},
// The default `.travis.yml` runs this scenario via `npm test`,
// not via `ember try`. It's still included here so that running
// `ember try:each` manually or from a customized CI config will run it
// along with all the other scenarios.
{
name: 'ember-default',
npm: {
devDependencies: {},
},
},
{
name: 'ember-default-with-jquery',
env: {
Expand All @@ -65,9 +55,9 @@ module.exports = async function () {
},
npm: {
devDependencies: {
'@ember/jquery': '^0.5.1',
},
},
'@ember/jquery': '^1.1.0'
}
}
},
{
name: 'ember-classic',
Expand Down
32 changes: 16 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
"deploy": "ember build --environment production && ember github-pages:commit --message \"Deploy gh-pages from commit $(git rev-parse HEAD)\" && git push origin gh-pages:gh-pages"
},
"devDependencies": {
"@ember/optional-features": "^1.3.0",
"@glimmer/component": "^1.0.0",
"@glimmer/tracking": "^1.0.0",
"@ember/optional-features": "^2.0.0",
"@glimmer/component": "^1.0.1",
"@glimmer/tracking": "^1.0.1",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-angle-bracket-invocation-polyfill": "^2.0.2",
"ember-cli": "~3.17.0",
"ember-cli": "~3.21.2",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-fastboot": "^2.0.4",
"ember-cli-fastboot-testing": "^0.4.0",
Expand All @@ -29,7 +29,7 @@
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-sass": "^10.0.1",
"ember-cli-sri": "^2.1.1",
"ember-cli-uglify": "^3.0.0",
"ember-cli-terser": "^4.0.0",
"ember-composable-helpers": "^2.3.1",
"ember-decorators-polyfill": "^1.1.1",
"ember-disable-prototype-extensions": "^1.1.3",
Expand All @@ -40,30 +40,30 @@
"ember-modifier": "^1.0.2",
"ember-named-arguments-polyfill": "^1.0.0",
"ember-qunit": "^4.6.0",
"ember-resolver": "^7.0.0",
"ember-source": "~3.17.0",
"ember-source-channel-url": "^2.0.1",
"ember-template-lint": "^2.4.0",
"ember-resolver": "^8.0.2",
"ember-source": "~3.21.1",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^2.11.0",
"ember-try": "^1.4.0",
"eslint": "^7.0.0",
"eslint-plugin-ember": "^8.4.0",
"eslint-plugin-node": "^11.0.0",
"eslint": "^7.8.0",
"eslint-plugin-ember": "^8.13.0",
"eslint-plugin-node": "^11.1.0",
"highlight.js": "^9.12.0",
"husky": "^4.2.1",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.0.2",
"pretty-quick": "^2.0.1",
"qunit-dom": "^1.1.0",
"qunit-dom": "^1.4.0",
"sass": "^1.22.1",
"uuid": "^7.0.1"
},
"dependencies": {
"@ember/render-modifiers": "^1.0.1",
"clipboard": "^2.0.6",
"ember-auto-import": "^1.5.3",
"ember-cli-babel": "^7.20.2",
"ember-cli-htmlbars": "^4.2.3"
"ember-auto-import": "^1.6.0",
"ember-cli-babel": "^7.22.1",
"ember-cli-htmlbars": "^5.3.1"
},
"resolutions": {
"clean-css": "4.2.1"
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/app/app.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Application from '@ember/application';
import Resolver from 'ember-resolver';
import loadInitializers from 'ember-load-initializers';
import config from './config/environment';
import config from 'dummy/config/environment';

export default class App extends Application {
modulePrefix = config.modulePrefix;
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/app/router.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import EmberRouter from '@ember/routing/router';
import config from './config/environment';
import config from 'dummy/config/environment';

export default class Router extends EmberRouter {
location = config.locationType;
Expand Down
7 changes: 5 additions & 2 deletions tests/dummy/config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@
"packages": [
{
"name": "ember-cli",
"version": "3.17.0",
"version": "3.21.2",
"blueprints": [
{
"name": "addon",
"outputRepo": "https://github.com/ember-cli/ember-addon-output",
"codemodsSource": "ember-addon-codemods-manifest@1",
"isBaseBlueprint": true,
"options": ["--yarn", "--no-welcome"]
"options": [
"--yarn",
"--no-welcome"
]
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const browsers = [
'last 1 Safari versions',
];

const isCI = !!process.env.CI;
const isCI = Boolean(process.env.CI);
const isProduction = process.env.EMBER_ENV === 'production';

if (isCI || isProduction) {
Expand Down
4 changes: 2 additions & 2 deletions tests/test-helper.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Application from '../app';
import config from '../config/environment';
import Application from 'dummy/app';
import config from 'dummy/config/environment';
import { setApplication } from '@ember/test-helpers';
import { start } from 'ember-qunit';
import './helpers/flash-message';
Expand Down
Loading