Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-4.x #370

Merged
merged 1 commit into from
Oct 31, 2022
Merged

ember-4.x #370

merged 1 commit into from
Oct 31, 2022

Conversation

jkusa
Copy link
Owner

@jkusa jkusa commented Oct 19, 2022 •
edited
Loading

resolves #190

@jkusa jkusa marked this pull request as draft October 19, 2022 02:18
@jkusa jkusa force-pushed the ember-4 branch 6 times, most recently from 4a9b392 to 43a89a5 Compare October 19, 2022 05:48
@jkusa jkusa changed the title Ember 4 ember-4.x Oct 19, 2022
kevinhinterlong
kevinhinterlong reviewed Oct 19, 2022
View reviewed changes
addon/components/copy-button.js

@forbidExtraArgs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This should be nice for helping with the arg rename

addon/modifiers/clipboard.js Outdated
clipboard.on(event, () => {
if (!element.disabled) {
const action = hash[`on${capitalize(event)}`];
action && action(...arguments);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action?.(...arguments)

README.md
@clipboardText="text to be copied"
@success={{this.onSuccess}}
@error={{this.onError}}
@text='text to be copied'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make these all "?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, yeah, we usually have this, I think prettier did that.

@jkusa jkusa force-pushed the ember-4 branch 2 times, most recently from 42314c6 to 6c1d1de Compare October 31, 2022 19:32
@jkusa jkusa marked this pull request as ready for review October 31, 2022 19:50
@jkusa
chore: update ember-auto-import to v2 & ember-cli v4
8c5b2b1 
BREAKING CHANGE: This commit contains many breaking changes:

  - Drops ember classic component support (glimmer only)
  - Drops support for `sendAction`
  - Requires ember-auto-import 2.x
  - `<CopyButton>` component arg name changes:

  | Old Argument Name  | New Argument Name                      |
  | ------------------ | -------------------------------------- |
  | `@clipboardText`   | `@text`                                |
  | `@clipboardTarget` | `@target`                              |
  | `@clipboardAction` | `@action`                              |
  | `@success`         | `@onSuccess`                           |
  | `@error`           | `@onError`                             |
  | `@title`           | no longer supported, pass as attribute |
  | `@disabled`        | no longer supported, pass as attribute |
  | `@aria-label`      | no longer supported, pass as attribute |
@jkusa jkusa merged commit 8e1aa28 into main Oct 31, 2022
@jkusa jkusa deleted the ember-4 branch October 31, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinhinterlong kevinhinterlong kevinhinterlong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embroider Support?
2 participants
@jkusa @kevinhinterlong