Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in ie #50

Merged
merged 1 commit into from
Jan 8, 2019
Merged

fix issue in ie #50

merged 1 commit into from
Jan 8, 2019

Conversation

ryanpatrickcook
Copy link
Contributor

seeing issue in ie11 where if copy button exists in document and user tries to transition away from the page and fails when copy button is tearing down

@jkusa
Copy link
Owner

jkusa commented Jan 7, 2019

@ryanpatrickcook thanks for reporting the issue and the PR🙏

Does the error happen all the time on ie11 or is it a timing issue? Does this happen even when a copy is successful?

@ryanpatrickcook
Copy link
Contributor Author

@jkusa seems to happen all the time. you don't even need to interact with copy-button component. just render it and tear down fails. so in our case, we would just render it on the page (no interaction from user with copy button), and then user would just do a simple transition from say from list page -> show page and transition would fail.

@jkusa
Copy link
Owner

jkusa commented Jan 8, 2019

@ryanpatrickcook Interesting. I wonder what the value of clipboard is on this line in e11:

https://github.com/jkusa/ember-cli-clipboard/pull/50/files#L76

@jkusa jkusa merged commit d9c5e59 into jkusa:master Jan 8, 2019
@jkusa
Copy link
Owner

jkusa commented Jan 8, 2019

@ryanpatrickcook you can find this change in v0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants