Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect GNUInstallDirs in CMake install rules #131

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Respect GNUInstallDirs in CMake install rules #131

merged 1 commit into from
Nov 5, 2020

Conversation

mablanchard
Copy link
Contributor

Prefer GNU standard locations over hard-coded ones.

Closes #129.

@mablanchard
Copy link
Contributor Author

mablanchard commented Nov 4, 2020 •
edited
Loading

Before/After on my machine (Fedora 32):

-- Installing: [...]/lib/cmake/nanoflann/nanoflannTargets.cmake
-- Installing: [...]/share/pkgconfig/nanoflann.pc
-- Installing: [...]/lib/cmake/nanoflann/nanoflannConfig.cmake
-- Installing: [...]/lib/cmake/nanoflann/nanoflannConfigVersion.cmake
-- Installing: [...]/include/nanoflann.hpp
...

-- Installing: [...]/lib64/cmake/nanoflann/nanoflannTargets.cmake
-- Installing: [...]/lib64/pkgconfig/nanoflann.pc
-- Installing: [...]/lib64/cmake/nanoflann/nanoflannConfig.cmake
-- Installing: [...]/lib64/cmake/nanoflann/nanoflannConfigVersion.cmake
-- Installing: [...]/include/nanoflann.hpp
...

@jlblancoc
Copy link
Owner

LGTM, thanks!

@jlblancoc jlblancoc merged commit 5bf5f79 into jlblancoc:master Nov 5, 2020
@mablanchard
Copy link
Contributor Author

LGTM, thanks!

Awesome, and thanks for the release @jlblancoc !

roehling added a commit to roehling/nanoflann that referenced this pull request Nov 5, 2020
@roehling
Install nanoflann arch-independently again
0fc05a1 
This is a tweak for PR jlblancoc#131 that undid the effect of PR jlblancoc#130 by
accident.
@roehling roehling mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlblancoc jlblancoc jlblancoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect CMake's GNUInstallDirs?
2 participants
@mablanchard @jlblancoc