Switch to C++ streams for index saving and loading #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces C++ streams instead of the C file handles used before. The intent here is to make the library more consistent w.r.t. its programming language usage and enable specific use cases that are hard to realize portably with C file handles (e.g. in-memory streams).
Some comments in response to @jlblancoc s comments in #156:
<iosfwd>
did not work out, as it only contains forward declarations of the stream classes, so we cannot use stream methods likeread
andwrite
directly in the header. My compiler only produced warnings for this, but they are rather annoying. Instead, I had to include<istream>
+<ostream>
.This fixes #156.