Skip to content

Commit

Permalink
testiso: add rw karg to iSCSI multipath test
Browse files Browse the repository at this point in the history
This is required by ostree.

This sometimes worked I think because `ignition-remount-sysroot.service`
has no ordering against `ostree-prepare-root.service` and so they'd
race. But really, we shouldn't rely on that Ignition unit.

See also: coreos#3789 (comment)
  • Loading branch information
jlebon committed May 8, 2024
1 parent bb60451 commit e2c8b89
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mantle/cmd/kola/testiso.go
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ func runTestIso(cmd *cobra.Command, args []string) (err error) {
case "manual":
butane_config = strings.ReplaceAll(iscsi_butane_config, "COREOS_INSTALLER_KARGS", "--append-karg netroot=iscsi:10.0.2.15::::iqn.2024-05.com.coreos:0")
case "ibft-with-mpath":
butane_config = strings.ReplaceAll(iscsi_butane_config, "COREOS_INSTALLER_KARGS", "--append-karg rd.iscsi.firmware=1 --append-karg rd.multipath=default --append-karg root=/dev/disk/by-label/dm-mpath-root")
butane_config = strings.ReplaceAll(iscsi_butane_config, "COREOS_INSTALLER_KARGS", "--append-karg rd.iscsi.firmware=1 --append-karg rd.multipath=default --append-karg root=/dev/disk/by-label/dm-mpath-root --append-karg rw")
default:
plog.Fatalf("Unknown test name:%s", test)
}
Expand Down

0 comments on commit e2c8b89

Please sign in to comment.