Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill editors on exit #44

Open
phdru opened this issue Nov 28, 2018 · 3 comments
Open

Kill editors on exit #44

phdru opened this issue Nov 28, 2018 · 3 comments

Comments

@phdru
Copy link
Contributor

phdru commented Nov 28, 2018

When the browser is closed by the user it kills textern (or textern terminates itself; I haven't' tested browser crash) but editors are left running. I think textern should kill editors on exit.

That's arguable, of course. My editor (vim) saves everything when being terminated so I don't care. But I can imagine there are people who would like their editors to left running so they can save before quitting.

Ideally, that should be configurable in the web interface. In that case web extension part must send the configuration option to the native part.

@cassava
Copy link

cassava commented Sep 16, 2020

While issues such as #60 exist, this "feature" should probably not be merged without an option to disable it.

@jlebon
Copy link
Owner

jlebon commented Sep 22, 2020

I agree this should be configurable. And then we can make it opt-in instead of opt-out so we retain the current behaviour.

@phdru
Copy link
Contributor Author

phdru commented Sep 24, 2020

Sorry for late answer — exceptionally busy at the job and gonna leave for a 2-weeks vacation.

I agree it should be configurable and off by default. Unfortunately I'm mostly a Python programmer. Can write a little bit of simple JavaScript for sites but not for an extension.

Can cooperate at the Python side if someone adds a checkbox in the settings and pass its value to the native code.

phdru added a commit to phdru/textern that referenced this issue Mar 7, 2021
Add interface to configure killing editors:
add a checkbox to turn the killing editors on/off; default is off;
add an input field for timeout between retries; default is 1 second.

Refs: jlebon#44.
phdru added a commit to phdru/textern that referenced this issue Mar 7, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 7, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 7, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 23, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 23, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 23, 2021
phdru added a commit to phdru/textern that referenced this issue Jul 31, 2021
Add interface to configure killing editors:
add a checkbox to turn the killing editors on/off; default is off;
add an input field for timeout between retries; default is 1 second.

Refs: jlebon#44.
phdru added a commit to phdru/textern that referenced this issue Jul 31, 2021
phdru added a commit to phdru/textern that referenced this issue Jul 31, 2021
phdru added a commit to phdru/textern that referenced this issue Jul 31, 2021
phdru added a commit to phdru/textern that referenced this issue Aug 2, 2021
phdru added a commit to phdru/textern that referenced this issue Mar 14, 2023
Add interface to configure killing editors:
add a checkbox to turn the killing editors on/off; default is off.

Refs: jlebon#44.
phdru added a commit to phdru/textern that referenced this issue Mar 14, 2023
phdru added a commit to phdru/textern that referenced this issue Mar 14, 2023
phdru added a commit to phdru/textern that referenced this issue Mar 14, 2023
Use `setpriv --pdeathsig SIGTERM`;
for now this is a Linux-only solution.

Fixes: jlebon#44.
phdru added a commit to phdru/textern that referenced this issue Mar 17, 2023
Add interface to configure killing editors:
add a checkbox to turn the killing editors on/off; default is off.

Refs: jlebon#44.
phdru added a commit to phdru/textern that referenced this issue Mar 17, 2023
phdru added a commit to phdru/textern that referenced this issue Mar 17, 2023
phdru added a commit to phdru/textern that referenced this issue Mar 17, 2023
Use `setpriv --pdeathsig SIGTERM`;
for now this is a Linux-only solution.

Fixes: jlebon#44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants