Support for macOS, mainly by replacing inotify with watchgod, which works cross-plattform #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks cross-plattform
|
Neat, thanks for this!
Hmm, I haven't hacked on asyncio Python in a while, but I think we could get this to work. Will investigate. |
phdru
added a commit
to phdru/textern
that referenced
this pull request
Feb 24, 2024
`watchdog` is much more portable. Fixes: jlebon#46.
phdru
added a commit
to phdru/textern
that referenced
this pull request
Feb 24, 2024
`watchdog` is much more portable. Fixes: jlebon#46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #10 for more details. I've tested this under both Linux and macOS, and it worked fine for me.
Note that watchgod (isn't that name cute ;) does not use inotify/fsevents but file polling instead. I don't think the performance implications are terrible, but I admit it's not as pleasing to my nerd-sense of elegance.
My main reason for chosing it is that it offers an asyncio-compatible API, so it was really easy to integrate. Alternatives do exist, e.g. watchdog was mentioned in a previous issue comment, that uses inotify on Linux and FSEvents on macOS. However, its API is thread-based, and I have no idea how that could be integrated with asyncio, or whether that's even possible.