fix: allow to drop on items that cannot be dragged

jledentu · Sep 16, 2024 · f5830cd · f5830cd
2 parents 5468685 + 52d8411
commit f5830cd
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/components/FinderItem.vue b/src/components/FinderItem.vue
@@ -165,7 +165,7 @@ export default {
       this.treeModel.startDrag(this.node.id);
     },
     onDragOver(event) {
-      if (!this.canDrag) {
+      if (!this.dragEnabled) {
         return;
       }
 
@@ -182,7 +182,7 @@ export default {
         this.ghost.parentNode.removeChild(this.ghost);
         this.ghost = null;
       }
-      if (!this.canDrag) {
+      if (!this.dragEnabled) {
         return;
       }
 

diff --git a/src/components/__tests__/FinderItem.test.js b/src/components/__tests__/FinderItem.test.js
@@ -445,6 +445,26 @@ describe("FinderItem", () => {
 
         expect(dataTransfer.dropEffect).toBeUndefined();
       });
+
+      it("should set dataTransfer.dropEffect = `all` if `dragEnabled` is a function returning `false`", async () => {
+        const dataTransfer = {};
+        const wrapper = mount(FinderItem, {
+          propsData: {
+            treeModel,
+            node,
+            dragEnabled: () => false,
+            options: {
+              canDrop: () => true
+            }
+          }
+        });
+
+        await wrapper.trigger("dragover", {
+          dataTransfer
+        });
+
+        expect(dataTransfer.dropEffect).toBe("move");
+      });
     });
 
     describe("dragend", () => {