Update mocha version & fix should.be API use error.

A mocha defect silently ignored this for the previous package-lock mocha version (5.0.1). See the following issue and changelog: mochajs/mocha#3226 https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#502--2018-03-05 Test should have failed in all cases, but false passing occured with older mocha versions.
jleverenz · Nov 25, 2018 · 7453615 · 7453615
1 parent 7d1fa82
commit 7453615
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 31 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
   },
   "devDependencies": {
     "coffee-script": ">= 1.8.0",
-    "mocha": "^5.0.1",
+    "mocha": "^5.2.0",
     "request": ">= 2.9.203",
     "should": "^13.2.1",
     "sinon": "^1.17.4"

diff --git a/test/index.test.coffee b/test/index.test.coffee
@@ -154,7 +154,7 @@ describe 'livereload server startup', ->
   it 'should gracefully handle something running on the same port', (done) ->
     new_server = livereload.createServer({debug: true, port: 35729})
     new_server.on 'error', (err) ->
-      err.code.should.be("EADDRINUSE")
+      err.code.should.be.equal("EADDRINUSE")
 
     done()