Fix the TFJobs Dashboard UI

* The UI isn't able to list jobs in all namespaces because the cluster role binding isn't using the correct role Related to kubeflow/trainer#836
jlewi · Oct 5, 2018 · 36f0f8d · 36f0f8d
1 parent 9271ebc
commit 36f0f8d
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 4 deletions.
diff --git a/kubeflow/core/tests/tf-job_test.jsonnet b/kubeflow/core/tests/tf-job_test.jsonnet
@@ -520,4 +520,32 @@ std.assertEqual(
       },
     ],
   }
-)
+) 
+
+&&
+
+std.assertEqual(
+  tfjobv1alpha1.tfUiRoleBinding,
+  {
+    apiVersion: "rbac.authorization.k8s.io/v1beta1",
+    kind: "ClusterRoleBinding",
+    metadata: {
+      labels: {
+        app: "tf-job-dasbhoard",
+      },
+      name: "tf-job-dashboard",
+    },
+    roleRef: {
+      apiGroup: "rbac.authorization.k8s.io",
+      kind: "ClusterRole",
+      name: "tf-job-dashboard",
+    },
+    subjects: [
+      {
+        kind: "ServiceAccount",
+        name: "tf-job-dashboard",
+        namespace: "test-kf-001",
+      },
+    ],
+  }
+) 
diff --git a/kubeflow/core/tf-job-operator.libsonnet b/kubeflow/core/tf-job-operator.libsonnet
@@ -486,9 +486,9 @@
       },
       subjects: [
         {
-          kind: tfServiceAccount.kind,
-          name: tfServiceAccount.metadata.name,
-          namespace: tfServiceAccount.metadata.namespace,
+          kind: tfUiServiceAccount.kind,
+          name: tfUiServiceAccount.metadata.name,
+          namespace: tfUiServiceAccount.metadata.namespace,
         },
       ],
     },