add file and line information

add file and line to tooltips add file and line to anonymous methods
jlfwong · Sep 27, 2021 · 66676e8 · 66676e8
1 parent e37f6fa
commit 66676e8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/views/flamechart-pan-zoom-view.tsx b/src/views/flamechart-pan-zoom-view.tsx
@@ -234,7 +234,9 @@ export class FlamechartPanZoomView extends Component<FlamechartPanZoomViewProps,
 
           const trimmedText = trimTextMid(
             ctx,
-            frame.node.frame.name,
+            frame.node.frame.name === '(anonymous)' && frame.node.frame.file
+              ? `(anonymous ${frame.node.frame.file.split('/').pop()}:${frame.node.frame.line})`
+              : frame.node.frame.name,
             physicalLabelBounds.width() - 2 * LABEL_PADDING_PX,
           )
 

diff --git a/src/views/flamechart-view.tsx b/src/views/flamechart-view.tsx
@@ -80,6 +80,7 @@ export class FlamechartView extends StatelessComponent<FlamechartViewProps> {
     if (!hover) return null
     const {width, height, left, top} = this.container.getBoundingClientRect()
     const offset = new Vec2(hover.event.clientX - left, hover.event.clientY - top)
+    const frame = hover.node.frame
 
     const style = this.getStyle()
 
@@ -88,7 +89,12 @@ export class FlamechartView extends StatelessComponent<FlamechartViewProps> {
         <span className={css(style.hoverCount)}>
           {this.formatValue(hover.node.getTotalWeight())}
         </span>{' '}
-        {hover.node.frame.name}
+        {frame.name}
+        {frame.file ? (
+          <div>
+            {frame.file}:{frame.line}
+          </div>
+        ) : undefined}
       </Hovertip>
     )
   }

diff --git a/src/views/flamechart-wrapper.tsx b/src/views/flamechart-wrapper.tsx
@@ -41,13 +41,19 @@ export class FlamechartWrapper extends StatelessComponent<FlamechartViewProps> {
     const {width, height, left, top} = this.container.getBoundingClientRect()
     const offset = new Vec2(hover.event.clientX - left, hover.event.clientY - top)
     const style = getStyle(this.props.theme)
+    const frame = hover.node.frame
 
     return (
       <Hovertip containerSize={new Vec2(width, height)} offset={offset}>
         <span className={css(style.hoverCount)}>
           {this.formatValue(hover.node.getTotalWeight())}
         </span>{' '}
-        {hover.node.frame.name}
+        {frame.name}
+        {frame.file ? (
+          <div>
+            {frame.file}:{frame.line}
+          </div>
+        ) : undefined}
       </Hovertip>
     )
   }