Increase contrast for search results

jlfwong · Nov 12, 2020 · f3e2119 · f3e2119
1 parent 2a19c36
commit f3e2119
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/src/views/flamechart-pan-zoom-view.tsx b/src/views/flamechart-pan-zoom-view.tsx
@@ -350,7 +350,7 @@ export class FlamechartPanZoomView extends Component<FlamechartPanZoomViewProps,
     matchedFrameBatch.fill(ctx, theme.searchMatchPrimaryColor)
     matchedTextHighlightBatch.fill(ctx, theme.searchMatchSecondaryColor)
     fadedLabelBatch.fill(ctx, theme.fgSecondaryColor)
-    labelBatch.fill(ctx, theme.fgPrimaryColor)
+    labelBatch.fill(ctx, this.props.searchResults != null ? theme.searchMatchTextColor : theme.fgPrimaryColor)
     indirectlySelectedOutlineBatch.stroke(ctx, theme.selectionSecondaryColor, frameOutlineWidth)
     directlySelectedOutlineBatch.stroke(ctx, theme.selectionPrimaryColor, frameOutlineWidth)
 

diff --git a/src/views/themes/dark-theme.ts b/src/views/themes/dark-theme.ts
@@ -16,8 +16,8 @@ enum Colors {
   BLUE = '#00769B',
   PALE_BLUE = '#004E75',
   GREEN = '#0F8A42',
-  LIGHT_BROWN = '#8A6D07',
-  BROWN = '#624406',
+  LIGHT_BROWN = '#D6AE24',
+  BROWN = '#A66F1C',
 }
 
 const C_0 = 0.2
@@ -60,6 +60,7 @@ export const darkTheme: Theme = {
 
   weightColor: Colors.GREEN,
 
+  searchMatchTextColor: Colors.DARKER_GRAY,
   searchMatchPrimaryColor: Colors.BROWN,
   searchMatchSecondaryColor: Colors.LIGHT_BROWN,
 

diff --git a/src/views/themes/light-theme.ts b/src/views/themes/light-theme.ts
@@ -60,6 +60,7 @@ export const lightTheme: Theme = {
 
   weightColor: Colors.GREEN,
 
+  searchMatchTextColor: Colors.BLACK,
   searchMatchPrimaryColor: Colors.ORANGE,
   searchMatchSecondaryColor: Colors.YELLOW,
 

diff --git a/src/views/themes/theme.tsx b/src/views/themes/theme.tsx
@@ -21,6 +21,7 @@ export interface Theme {
 
   weightColor: string
 
+  searchMatchTextColor: string
   searchMatchPrimaryColor: string
   searchMatchSecondaryColor: string