Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidentally added/retained dependencies on react and react-redux #315

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Remove accidentally added/retained dependencies on react and react-redux #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86f3a1a
Remove react from dependencies
jlfwong Sep 29, 2020
9312db0
Remove accidentally dependencies on react and react-redux
jlfwong Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 7 additions & 66 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"preact": "10.4.1",
"prettier": "2.0.4",
"protobufjs": "6.8.8",
"react-redux": "^7.2.0",
"redux": "^4.0.5",
"ts-jest": "24.3.0",
"typescript": "3.9.2",
Expand Down Expand Up @@ -79,7 +78,6 @@
]
},
"dependencies": {
"open": "7.2.0",
"react": "^16.13.1"
"open": "7.2.0"
}
}
2 changes: 1 addition & 1 deletion src/lib/preact-redux.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* As of Preact 10.x, they no longer have an officially supported preact-redux library.
* It's possible to use react-redux with some hacks, but these hacks cause npm run pack
* to error out because of (intentinoally) unmet peer dependencies.
* to error out because of (intentionally) unmet peer dependencies.
*
* I could stack more hacks to fix this problem, but I'd rather just drop the dependency
* and remove the need to do any dependency hacking by writing the very small part of
Expand Down