Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accept header to be specified alongside profileURL #461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlakeWilliams
Copy link

@BlakeWilliams BlakeWilliams commented Jan 5, 2024

I have an endpoint I'd like to profile that returns HTML or JSON based on the accept header. By default it returns JSON but I'd like to provide a quick link via profileURL that will profile the HTML response instead.

Since speedscope doesn't specify an accept header fetch defaults to */*, which ends up using the default format of that endpoint. I'd like to be able to specify the accept header explicitly so I can generate quick links to both JSON And HTML profiles.

To solve that ask, this adds a new parameter to the hash based param logic, profileAccepts (better name suggestions welcome). This allows you to specify the accept header so that you can explicitly choose which content type to profile when using #profileURL.

Usage: https://speedscope.app/#profileURL=http://mywebsite/page-to-profile&#profileAccepts=application%2Fjson

I didn't update the README or add any documentation, but happy to if requested!

I have an endpoint I'd like to profile that returns HTML or JSON based
on the accept header. By default it returns JSON but I'd like to provide
a quick link via `profileURL` that will profile the HTML response
instead.

Since speedscope doesn't specify an accept header `fetch` defaults to
`*/*` which ends up using the default value of that endpoint. I'd like
to be able to specify the accept header explicitly so I can generate
quick links to both JSON And HTML profiles.

To solve that ask, this adds a new parameter to the hash based param
logic, `profileAccepts`. This allows you to specify the accept header so
that you can explicitly choose which content type to profile when using
`#profileURL`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant