-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LineReader Candidate: tests for sorting and potential int overflow fix (
#762)
- Loading branch information
Showing
3 changed files
with
78 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
* Copyright (c) 2021, the original author or authors. | ||
* | ||
* This software is distributable under the BSD license. See the terms of the | ||
* BSD license in the documentation provided with this software. | ||
* | ||
* https://opensource.org/licenses/BSD-3-Clause | ||
*/ | ||
package org.jline.reader; | ||
|
||
import org.junit.Test; | ||
|
||
import java.util.Arrays; | ||
import java.util.Collections; | ||
import java.util.List; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
|
||
public class CandidateTest { | ||
|
||
@Test | ||
public void testCandidatesSortedByValue() { | ||
List<Candidate> candidates = Arrays.asList( | ||
new Candidate("cand3", "cand3", null, null, null, null, true), | ||
new Candidate("cand1", "cand1", null, null, null, null, true), | ||
new Candidate("cand2", "cand2", null, null, null, null, true) | ||
); | ||
Collections.sort(candidates); | ||
|
||
assertEquals("cand1", candidates.get(0).value()); | ||
assertEquals("cand2", candidates.get(1).value()); | ||
assertEquals("cand3", candidates.get(2).value()); | ||
} | ||
|
||
@Test | ||
public void testCandidatesSortedBySortProperty() { | ||
List<Candidate> candidates = Arrays.asList( | ||
new Candidate("cand3", "cand3", null, null, null, null, true, 3), | ||
new Candidate("cand1", "cand1", null, null, null, null, true, 1), | ||
new Candidate("cand2", "cand2", null, null, null, null, true, 2) | ||
); | ||
Collections.sort(candidates); | ||
|
||
assertEquals("cand1", candidates.get(0).value()); | ||
assertEquals("cand2", candidates.get(1).value()); | ||
assertEquals("cand3", candidates.get(2).value()); | ||
} | ||
|
||
@Test | ||
public void testCandidatesSortedByValueAndSortProperty() { | ||
List<Candidate> candidates = Arrays.asList( | ||
new Candidate("cand3", "cand3", null, null, null, null, true, -3), | ||
new Candidate("aaa", "cand1", null, null, null, null, true), | ||
new Candidate("cand2", "cand2", null, null, null, null, true, 2) | ||
); | ||
Collections.sort(candidates); | ||
|
||
assertEquals("cand3", candidates.get(0).value()); | ||
assertEquals("aaa", candidates.get(1).value()); | ||
assertEquals("cand2", candidates.get(2).value()); | ||
} | ||
|
||
@Test | ||
public void testCandidatesSortedByCornerSortProps() { | ||
List<Candidate> candidates = Arrays.asList( | ||
new Candidate("cand1", "cand1", null, null, null, null, true, 1), | ||
new Candidate("cand2", "cand2", null, null, null, null, true, Integer.MAX_VALUE), | ||
new Candidate("cand3", "cand3", null, null, null, null, true, Integer.MIN_VALUE) | ||
); | ||
Collections.sort(candidates); | ||
|
||
assertEquals("cand3", candidates.get(0).value()); | ||
assertEquals("cand1", candidates.get(1).value()); | ||
assertEquals("cand2", candidates.get(2).value()); | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
reader/src/test/java/org/jline/reader/LineReaderBuilderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters