Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate completion sort order skips candidates #956

Closed
valepakh opened this issue Mar 21, 2024 · 0 comments · Fixed by #957
Closed

Duplicate completion sort order skips candidates #956

valepakh opened this issue Mar 21, 2024 · 0 comments · Fixed by #957
Milestone
3.26.0

Comments

@valepakh
Copy link
Contributor

If several candidates have the same sort order, only the first one appears in the suggestions.
Looking into the Candidate.compareTo method I'd assume that in this case default sort should apply.
@valepakh valepakh mentioned this issue Mar 21, 2024
Merged
valepakh added a commit to unisonteam/ignite-3 that referenced this issue Mar 21, 2024
@valepakh
IGNITE-21674 Fix subcommand completion in CLI
e205ccc 
Add a workaround for jline/jline3#956
@valepakh valepakh mentioned this issue Mar 21, 2024
Merged
valepakh added a commit to unisonteam/ignite-3 that referenced this issue Mar 21, 2024
@valepakh
IGNITE-21674 Fix subcommand completion in CLI
217fde1 
Add a workaround for jline/jline3#956
PakhomovAlexander pushed a commit to apache/ignite-3 that referenced this issue Mar 22, 2024
@valepakh
IGNITE-21674 Fix subcommand completion in CLI (#3461)
104b490 
Add a workaround for jline/jline3#956
gnodet pushed a commit that referenced this issue Apr 17, 2024
@valepakh
Use default sort order when custom sort order is identical (fixes #956)…
b982407 
… (#957)
@gnodet gnodet added this to the 3.26.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.26.0
Development

Successfully merging a pull request may close this issue.

Use default sort order when custom sort order is identical valepakh/jline3
2 participants
@gnodet @valepakh