Fix history trim for non-timestamped files #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Do you think you could add a small unit test for that ? |
gnodet
approved these changes
Oct 20, 2023
gnodet
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a report today from a user that there is an issue saving the console history. This is due to the fact that the console history can be timestamped (format
<timestamp>:<line>) but also just the raw line (format<line>). The trim process tries to find the delimiter char:everytime, and errors out if the console history is not timestamped:I've changed the trim process in a way that it checks if the history is timestamped, and if not there is no split applied and the line is just parsed raw. The time is not used in the further trim steps.