Fix 'Missing newline before ")"' when no params

Avoid checking "parameter-list-wrapping" rule when the element doesn't have parameters. Fixes pinterest#327
jlmd · Mar 31, 2019 · f9b3dbb · f9b3dbb
1 parent 056d983
commit f9b3dbb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/...rd/src/main/kotlin/com/github/shyiko/ktlint/ruleset/standard/ParameterListWrappingRule.kt b/...rd/src/main/kotlin/com/github/shyiko/ktlint/ruleset/standard/ParameterListWrappingRule.kt
@@ -39,6 +39,8 @@ class ParameterListWrappingRule : Rule("parameter-list-wrapping") {
             return
         }
         if (node.elementType == VALUE_PARAMETER_LIST &&
+            // skip when there are no parameters
+            node.firstChildNode?.treeNext?.elementType != RPAR &&
             // skip lambda parameters
             node.treeParent?.elementType != FUNCTION_LITERAL
         ) {

diff --git a/...rc/test/kotlin/com/github/shyiko/ktlint/ruleset/standard/ParameterListWrappingRuleTest.kt b/...rc/test/kotlin/com/github/shyiko/ktlint/ruleset/standard/ParameterListWrappingRuleTest.kt
@@ -62,6 +62,20 @@ class ParameterListWrappingRuleTest {
         )
     }
 
+    @Test
+    fun testLintClassParameterListWhenMaxLineLengthExceededAndNoParameters() {
+        assertThat(
+            ParameterListWrappingRule().lint(
+                """
+                class ClassAWithALongName()
+                """.trimIndent(),
+                userData = mapOf("max_line_length" to "10")
+            )
+        ).doesNotContain(
+            LintError(1, 27, "parameter-list-wrapping", """Missing newline before ")"""")
+        )
+    }
+
     @Test
     fun testLintClassParameterListValid() {
         assertThat(