Add encryption stubbing #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfwright
force-pushed
the
feature/stub-encryption
branch
7 times, most recently
from
d3f5e8c
to
2d1fcdd
Compare
| CryptKeeper.stub_encryption = true | ||
| CryptKeeper::Provider::Encryptor.any_instance.should_not_receive(:decrypt) | ||
| subject.find(record.id).storage | ||
| CryptKeeper.stub_encryption = false |
There was a problem hiding this comment.
Can you put stub_encryption = false in an after block?
tfwright
force-pushed
the
feature/stub-encryption
branch
from
e643ab0
to
a2bc086
Compare
| CryptKeeper.stub_encryption = true | ||
| record = subject.create!(storage: "testing") | ||
| CryptKeeper::Provider::Encryptor.any_instance.should_not_receive(:decrypt) | ||
| subject.find(record.id).storage |
There was a problem hiding this comment.
rather than using should_not_receive, how about just asserting that the plaintext of storage is unchanged.
There was a problem hiding this comment.
It's a bit tricky skirting deserialization, but I suppose it could work. I was following the pattern in other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows stubbing encryption with
CryptKeeper.stub_encryption = true