Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore set temperature changes from underlying if outside of configured min/max range #576

Closed
gpayer opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@gpayer
Copy link
Collaborator

gpayer commented Oct 23, 2024

Any set temperature changes sent by an underlying should be filtered by using the configured min/max temperature values.
This way VTherm usage via the HA UI and via an underlying behave the same way.

Is your feature request related to a problem? Please describe.
And additionally stupid behaviour (like sending a set temperature of 5.0 °C if switched off) by underlyings (looking at you, Bosch BTH-RA) is ignored.

Describe alternatives you've considered
Abusing the light auto-correction, so set temperature changes from underlyings are ignored. However this might lead to suboptimal heating behaviour.

Originally I had planned to implement this myself, as this is a pretty minor change, but I simply can't find the time to do so.

@jmcollin78
Copy link
Owner

Hello @gpayer ,

Yes this is a nice suggestion. I would love a PR for doing that because, my time is also so short.
I could help if needed, i seems to be easy to implement.

@jmcollin78
Copy link
Owner

Thank you @gpayer !
You are now a member of the family contributor: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants