Filter out-of-range target temperature sent from underlying climate devices #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcollin78
reviewed
Oct 26, 2024
jmcollin78
reviewed
Oct 26, 2024
There was a problem hiding this comment.
Hello @gpayer ,
nice to see you take time to do the PR. I think there is a unit test failing now. Can you have a look please ?
|
Hey @jmcollin78, thanks for taking a look at my pull request. I fixed the broken test case, it was directly affected by my change, as it tried to set the temperature to a now filtered value. Now a different temperature is used and all is well. |
jmcollin78
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial goal was to filter out stupid data from my Bosch BTH-RA thermostat. But this change makes also sense in the grand scheme of things, because it unifies the user experience. It doesn't matter whether you change the target temperature via the HA frontend or directly with an underlying, min and max are considered in both scenarios.
At the moment there are no unit tests, as I still have to figure out how to create one for this scenario, but I will try to do that in the next days.
This implements #576.