Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuel hvac_off should be prioritized over window or auto-start/stop hvac_off #619

Closed
jmcollin78 opened this issue Nov 10, 2024 Discussed in #603 · 3 comments
Closed
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1

Comments

@jmcollin78
Copy link
Owner

Discussed in #603

Originally posted by t0mb080 November 4, 2024
I love the new auto on/off functionality, seems like a great feature so I turned it on to try.

However, I'm seeing some very strange behaviour when my thermostats are meant to be off. They are controlled by the scheduler component recommended in the docs but now they seem to be turning themselves on and off randomly through the day, when they're meant to be completely off. Even stranger is that sometimes it turns on at random times in heat/cool mode when the scheduler only ever turns it on in heat-only mode. My questions are:

  1. How do you tell the difference in state between the thermostat being off because it's been manually turned off, or turned off on a schedule versus when it's been automatically turned off by the algorithm and therefore might come back on again? Is this reported in the entity or sensor in some way? Without this it's quite hard to know what's going on.

  2. Is there potential for some strange interaction between schedules and the auto on/off? Imagine you have auto on/off on, the thermostat turns on because it's scheduled, then it's automatically turned off by the algorithm, and then the schedule turns it off. If the thermostat is already off (from the auto algorithm) when the scheduler is meant to turn it off, does that mean it might automatically turn back on again even though it's scheduled to be off? Could this be the cause of the weird turning on and off I've been seeing?

Thanks to @jmcollin78 and anyone else that might be able to shed light on this.

@jmcollin78
Copy link
Owner Author

B. When a VTherm is turned off, either manually or by scheduler, shouldn't the saved_havc_mode get reset to None so that it doesn't accidentally turn it back on again?

This is certainly what I should do (if I get the off event while the Vtherm is already off, i'm not of this). I should also remove the hvac_off_reson - an attribute which tells why the device was turned off. This can be : window_detection, auto_start_stop or manual.
Maybe in a more general way, a manual (human or Scheduler) turn off should be always prioritized vs window or auto_start_stop and take the "lead".

@jmcollin78 jmcollin78 added enhancement New feature or request P1 Priority 1 labels Nov 10, 2024
jmcollin78 pushed a commit that referenced this issue Nov 10, 2024
jmcollin78 added a commit that referenced this issue Nov 10, 2024
…to-start/stop hvac_off (#622)

Co-authored-by: Jean-Marc Collin <jean-marc.collin-extern@renault.com>
@jmcollin78 jmcollin78 added the developed When development is done and tested label Nov 10, 2024
@jmcollin78
Copy link
Owner Author

Hello @t0mb080,

Here is a beta release fixing the issue. Please give it a try on your real environment and with your real use case to see.

If ok I will release next week: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.6.3.beta1

@jmcollin78
Copy link
Owner Author

This have been released yesterday in 6.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1
Projects
None yet
Development

No branches or pull requests

1 participant