Skip to content

Commit

Permalink
Editorial: insert '!' and '?'; fix incorrect intrinsic names (tc39#1636)
Browse files Browse the repository at this point in the history
In PR tc39#1571:

https://github.com/tc39/ecma262/pull/1571/files#diff-3540caefa502006d8a33cb1385720803L19940
removed the step
"Assert: _constructorInfo_ is not an abrupt completion."
but didn't insert the equivalent "!" on the previous line.

https://github.com/tc39/ecma262/pull/1571/files#diff-3540caefa502006d8a33cb1385720803L23362
removed a ReturnIfAbrupt step,
but didn't insert the equivalent '?' in the previous line.

---

Commit f1b22ef (tc39#1376) changed 2 occurrences of
  "%AsyncIteratorPrototype%
to
  "%AsyncIterator.prototype%
but the latter assumes a well-known intrinsic named "%AsyncIterator%",
which doesn't exist.

This commit changes them back.

---

Commit f1b22ef (tc39#1376) changed lots of intrinsic-names
from old-style to new-style.

But these two should have stayed old-style,
so switch them back.

(See tc39#1636 (comment))
  • Loading branch information
jmdyck authored and ljharb committed Sep 16, 2019
1 parent 67bfb31 commit 9c0749b
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions spec.html
Original file line number Diff line number Diff line change
Expand Up @@ -19961,7 +19961,7 @@ <h1>Runtime Semantics: ClassDefinitionEvaluation</h1>
<pre><code class="javascript">constructor() {}</code></pre>
using the syntactic grammar with the goal symbol |MethodDefinition[~Yield, ~Await]|.
1. Set the running execution context's LexicalEnvironment to _classScope_.
1. Let _constructorInfo_ be DefineMethod of _constructor_ with arguments _proto_ and _constructorParent_.
1. Let _constructorInfo_ be ! DefineMethod of _constructor_ with arguments _proto_ and _constructorParent_.
1. Let _F_ be _constructorInfo_.[[Closure]].
1. If |ClassHeritage_opt| is present, set _F_.[[ConstructorKind]] to `"derived"`.
1. Perform MakeConstructor(_F_, *false*, _proto_).
Expand Down Expand Up @@ -23379,7 +23379,7 @@ <h1>Runtime Semantics: Evaluation</h1>
</emu-alg>
<emu-grammar>ExportDeclaration : `export` `default` ClassDeclaration</emu-grammar>
<emu-alg>
1. Let _value_ be BindingClassDeclarationEvaluation of |ClassDeclaration|.
1. Let _value_ be ? BindingClassDeclarationEvaluation of |ClassDeclaration|.
1. Let _className_ be the sole element of BoundNames of |ClassDeclaration|.
1. If _className_ is `"*default*"`, then
1. Let _env_ be the running execution context's LexicalEnvironment.
Expand Down Expand Up @@ -24660,7 +24660,7 @@ <h1>Object.values ( _O_ )</h1>
<h1>Properties of the Object Prototype Object</h1>
<p>The Object prototype object:</p>
<ul>
<li>is the intrinsic object <dfn>%Object.prototype%</dfn>.</li>
<li>is the intrinsic object <dfn>%ObjectPrototype%</dfn>.</li>
<li>is an immutable prototype exotic object.</li>
<li>has a [[Prototype]] internal slot whose value is *null*.</li>
</ul>
Expand Down Expand Up @@ -37092,7 +37092,7 @@ <h1>The %AsyncFromSyncIteratorPrototype% Object</h1>
<ul>
<li>has properties that are inherited by all Async-from-Sync Iterator Objects.</li>
<li>is an ordinary object.</li>
<li>has a [[Prototype]] internal slot whose value is %AsyncIterator.prototype%.</li>
<li>has a [[Prototype]] internal slot whose value is %AsyncIteratorPrototype%.</li>
<li>has the following properties:</li>
</ul>

Expand Down Expand Up @@ -37656,7 +37656,7 @@ <h1>Properties of the AsyncGenerator Prototype Object</h1>
<li>is the initial value of the `prototype` property of %AsyncGenerator% (the AsyncGeneratorFunction.prototype).</li>
<li>is an ordinary object.</li>
<li>is not an AsyncGenerator instance and does not have an [[AsyncGeneratorState]] internal slot.</li>
<li>has a [[Prototype]] internal slot whose value is %AsyncIterator.prototype%.</li>
<li>has a [[Prototype]] internal slot whose value is %AsyncIteratorPrototype%.</li>
<li>has properties that are indirectly inherited by all AsyncGenerator instances.</li>
</ul>

Expand Down Expand Up @@ -38792,7 +38792,7 @@ <h1>Properties of the AsyncFunction Prototype Object</h1>
<li>is an ordinary object.</li>
<li>is not a function object and does not have an [[ECMAScriptCode]] internal slot or any other of the internal slots listed in <emu-xref href="#table-27"></emu-xref>.</li>
<li>is the value of the `prototype` property of %AsyncFunction%.</li>
<li>is the intrinsic object <dfn>%AsyncFunction.prototype%</dfn>.</li>
<li>is the intrinsic object <dfn>%AsyncFunctionPrototype%</dfn>.</li>
<li>has a [[Prototype]] internal slot whose value is %Function.prototype%.</li>
</ul>

Expand Down

0 comments on commit 9c0749b

Please sign in to comment.