Add test cases for whitespace #16
Conversation
This test will catch implementation bugs related to whitespace. jmespath/jmespath.js#58
tests/basic.json
Outdated
| { | ||
| "expression": "foo\t.\tbar\t.\tbaz", | ||
| "result": "correct" | ||
| }, |
There was a problem hiding this comment.
Trailing whitespace here.
There was a problem hiding this comment.
Are you talking about the code or the test case?
Do you want the test expression to have a trailing \t?
There was a problem hiding this comment.
No, in the actual json document. ;)
There was a problem hiding this comment.
Should have said: "Please can you remove the trailing space characters on this line". Sorry!
There was a problem hiding this comment.
The one time I don't use my own IDE, 20% of LOC contain errors =D
tests/basic.json
Outdated
| { | ||
| "expression": "foo\r.\rbar\r.\rbaz", | ||
| "result": "correct" | ||
| }, |
tests/basic.json
Outdated
| { | ||
| "expression": "foo\r\n.\r\nbar\r\n.\r\nbaz", | ||
| "result": "correct" | ||
| }, |
|
I know this is super, super late for feedback, but I won't be able to take this change. While most of the implementations ignore some degree of whitespace at the lexing stage, the grammar for jmespath uses ABNF which is strict about requiring whitespace to be explicitly modeled. From Section 3.1 of RFC 4234:
If we're going to support whitespace around expressions we would need to update the spec/grammar first, and I'm not sure at this point it's something we'd want to do (though I'm open to a discussion about it). |
This test will catch implementation bugs related to whitespace.
jmespath/jmespath.js#58