-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to testcontainers #107
Switch to testcontainers #107
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic Password | 2777cb9 | vaultrs-tests/tests/api_tests/userpass.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The git guardian warning is because I introduced hard-coded private keys to ease the test setup. |
08d219a
to
df32c5a
Compare
If fixed the GitGuardian issue, @Haennetz do you know when you will have some bandwidth to review this? |
I hope that i can review it on Wednesday |
I need some additional time to review it I will finish the review on Friday. Looks really good so fare. Nice work 👍 |
Thanks for taking a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stormshield-gt Really nice work, I only have 3 questions, that are only out of curiosity. I will approve it already. You should be able to merge it by your self.
df32c5a
to
65ef402
Compare
Thanks again for your review @Haennetz, I will merge this now |
Fixes #80
This PR migrates the whole test suite to testcontainers.
This notably removes dependencies against the unmaintained
dockertest
anddockertest-server
. This will unlock #68 and other developments that were blocked by upstream issues. Notably we can now bump the testedVault
version.To be able to run tests in parallel and factorize the test setup logic, I've introduced a new crate
vaultrs-tests
and update the CI accordingly.The CI workflow now go from 9m 18s to 4m 23s. The local test duration is also greatly reduced.