Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup testsuite #113

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

stormshield-gt
Copy link
Collaborator

Cleanup the further the testsuite by doing the following:

  • Remove assert!(result.is_ok()) pattern, which gives less context in case of failure than result.unwrap()
  • Move the example of the README directly inside the lib.rs to compile them. Fix some examples that silently didn't compile until then.
  • Fix doc generation warning and add a ci check for it
  • Detect slow test with cargo +nightly t --workspace -- -Z unstable-options --report-time --format json 2> /dev/null | jq and ignore them locally. This improves the developer experience.
  • Update README to new test location since testscontainers migration

I split the PR into several commits to ease the review.

@stormshield-gt
Copy link
Collaborator Author

Hi @Haennetz, happy new year!
Just a friendly ping; Do you think you will have some bandwidth soon to review this soon?

@Haennetz
Copy link
Collaborator

Haennetz commented Jan 7, 2025

Happy new year 🎉🎊
I will review it until Sunday.

Copy link
Collaborator

@Haennetz Haennetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work 👍

@stormshield-gt stormshield-gt merged commit 1a40002 into jmgilman:master Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants