Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL-Encoding in Path applied twice #56

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Fix URL-Encoding in Path applied twice #56

merged 2 commits into from
Feb 24, 2024

Conversation

darkecho731
Copy link
Contributor

closes #55

darkecho731
darkecho731 commented Apr 5, 2023
View reviewed changes
src/api.rs Outdated Show resolved Hide resolved
Haennetz
Haennetz reviewed Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@Haennetz Haennetz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Fix, and sorry for the delayed review
I think the solution I provided would be more efficient then the current implementation, because we don't need to convert the path segments in new Vec.

src/api.rs Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
tests/kv2.rs Outdated Show resolved Hide resolved
@Haennetz
Copy link
Collaborator

Also, please rebase your branch

@darkecho731 darkecho731 force-pushed the fix_double_url_encoding branch from f483efa to 6d0e877 Compare February 24, 2024 16:09
@darkecho731
Copy link
Contributor Author

Hi, I have implemented the proposed changes.

@Haennetz Haennetz merged commit 72375e6 into jmgilman:master Feb 24, 2024
7 checks passed
@Haennetz
Copy link
Collaborator

Thanks the fix will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haennetz Haennetz Haennetz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL-Encoding in Path is applied twice
2 participants
@darkecho731 @Haennetz