Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client TLS #62

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

outscale-fba
Copy link
Contributor

Add support for client TLS certificates in order to authenticates client side connections.

It uses vault environment variables (as specified here: https://developer.hashicorp.com/vault/docs/commands) as default values.

Implementation is done for the rustls feature and still need to be implemented for native-tls.

@thorhs
Copy link
Contributor

thorhs commented Jan 29, 2024

I would really like to get this feature in, I'm currently working on a project that would require certificate login, this would help alot.

@Haennetz
Copy link
Collaborator

Hey,
thanks for your pull request, and sorry for the delay.
We should also add support for the VAULT_CACERT environment variable. With that the users can also use a custom CA to validate certs.

@outscale-fba
Copy link
Contributor Author

Hello,

VAULT_CACERT env variable seems to be already supported here https://github.com/jmgilman/vaultrs/blob/master/src/client.rs#L235.

I there anything more to do ?

@Haennetz
Copy link
Collaborator

Sorry I missed that, thanks for pointing that out.

@Haennetz Haennetz merged commit e886cbc into jmgilman:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants