Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: create entity, read entity by name and create entity alias #64

Closed
wants to merge 10 commits into from

Conversation

slckl
Copy link
Contributor

@slckl slckl commented Sep 19, 2023

Probably replaces #38

Have the same need, entity and entity-alias allows applying vault policies to an identity.

Cleaned up the previous work by adding docs, and trimming some unnecessary changes.
I've also implemented an extra api call for obtaining entity by name, which is included in the test from the previous PR.

Could probably implement more of the identity API (somewhat easy thanks to the design of this library, good job), but have no use case for the rest of it right now.

Copy link
Collaborator

@Haennetz Haennetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thanks for your pull request, and sorry for the delay.
We should add a module identity and add submodules for entity and entity_alias.
It would be nice to provide a feature complete implementation for the entity and entity_alias endpoints.
If you have the time it would be great if you can add the identity API completely, otherwise I will create a new issue to do that.

Comment on lines +23 to +24
pub name: String,
pub policies: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub name: String,
pub policies: String,
pub name: String,
pub id: Option<String>,
pub metadata: Option<HashMap<String, String>>,
pub policies: Option<Vec<String>>,
pub disabled: Option<bool>,

pub request_id: String,
pub lease_id: String,
pub renewable: bool,
pub lease_duration: i64,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub lease_duration: i64,
pub lease_duration: u64,

@slckl
Copy link
Contributor Author

slckl commented Feb 24, 2024

Hey, glad to see some activity here.
I'm still using my fork for this in production, so I would love to upstream this.

Will check back next week how much I can do wrt the whole identity endpoint.

@Haennetz
Copy link
Collaborator

Haennetz commented Feb 24, 2024

It would be enough to add at least the entity and entity_alias endpoints. The rest of the identity secret engine can be done later.

@stormshield-gt
Copy link
Collaborator

I would be glad to give you a hand with this if you need any help. I'm also needing this right now, and the group endpoint too. I could advance this in my own branch if that's OK.

@stormshield-gt
Copy link
Collaborator

@slckl I hope you don't mind, I didn't wait for your response and continue the work in another PR. I supposed you will be fine to have somebody continue the work. I've credited you on the first commits

@slckl
Copy link
Contributor Author

slckl commented Mar 1, 2024

@stormshield-gt sounds good. It sounds like you're more eager for this than I am at the moment, so, ofc, go for it.
We can close this one, when your branch is merged probably.

@Haennetz
Copy link
Collaborator

I close this issue as well because we merged #77

@Haennetz Haennetz closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants