Skip to content

Commit

Permalink
Remove unimplemented feature flag: shippingFailure (open-telemetry#483)
Browse files Browse the repository at this point in the history
- Removal of shippingFailure feature flag, which is not implemented (doesn’t do anything).

Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 19, 2022
1 parent f2ebad2 commit 35d165e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion docs/feature_flags.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ feature flags.
| Feature Flag | Service(s) | Description |
|-------------------------|-----------------|---------------------------------------------------------------------------|
| `productCatalogFailure` | Product Catalog | Generate an error for `GetProduct` requests with product id: `OLJCESPC7Z` |
| `shippingFailure` | Shipping | Induce very long latency when shipping outside of USA |
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ defmodule Featureflagservice.Repo.Migrations.CreateFeatureflags do
description: "Fail product catalog service on a specific product",
enabled: false})

repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
name: "shippingFailure",
description: "Fail shipping service when shipping a product to a non-USA address",
enabled: false})

repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
name: "recommendationCache",
description: "Cache recommendations",
Expand All @@ -34,7 +29,6 @@ defmodule Featureflagservice.Repo.Migrations.CreateFeatureflags do

defp execute_down do
repo().delete(%Featureflagservice.FeatureFlags.FeatureFlag{name: "productCatalogFailure"})
repo().delete(%Featureflagservice.FeatureFlags.FeatureFlag{name: "shippingFailure"})
repo().delete(%Featureflagservice.FeatureFlags.FeatureFlag{name: "recommendationCache"})
end
end

0 comments on commit 35d165e

Please sign in to comment.