fix: pass proper env var to tracetesting Dockerfile (open-telemetry#1283

) * fix: pass proper env var to tracetesting Dockerfile * chore: update changelog * chore: update changelog
jmichalak9 · Dec 6, 2023 · a147f19 · a147f19
1 parent b296ff3
commit a147f19
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,8 @@ release.
   ([#1266](https://github.com/open-telemetry/opentelemetry-demo/pull/1266))
 * [accountingservice] Add additional attributes to Kafka spans
   ([#1286](https://github.com/open-telemetry/opentelemetry-demo/pull/1286))
+* fix env var for pinning trace-based test tool version
+  ([#1283](https://github.com/open-telemetry/opentelemetry-demo/pull/1283))
 
 ## 1.6.0
 

diff --git a/docker-compose.minimal.yml b/docker-compose.minimal.yml
@@ -639,6 +639,8 @@ services:
     build:
       context: ./
       dockerfile: ./test/tracetesting/Dockerfile
+      args:
+        - TRACETEST_IMAGE_VERSION
     environment:
       - AD_SERVICE_ADDR
       - CART_SERVICE_ADDR

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -784,6 +784,8 @@ services:
     build:
       context: ./
       dockerfile: ./test/tracetesting/Dockerfile
+      args:
+        - TRACETEST_IMAGE_VERSION
     environment:
       - AD_SERVICE_ADDR
       - CART_SERVICE_ADDR

diff --git a/test/tracetesting/Dockerfile b/test/tracetesting/Dockerfile
@@ -6,6 +6,8 @@ FROM alpine
 
 WORKDIR /app
 
+ARG TRACETEST_IMAGE_VERSION
+
 RUN apk --update add bash jq curl
 RUN curl -L https://raw.githubusercontent.com/kubeshop/tracetest/main/install-cli.sh | bash -s -- ${TRACETEST_IMAGE_VERSION}