Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update expected exception when translation not found #136

Merged
merged 2 commits into from
Jun 24, 2020
Merged

README: Update expected exception when translation not found #136

merged 2 commits into from
Jun 24, 2020

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Jun 24, 2020

Changes proposed in this pull request:


  • Just one thing left, which I don't think needs to be runnable:
$ byexample -x-shebang 'python:/Library/Frameworks/Python.framework/Versions/3.8/bin/python3 %a' -l python -o '+force-echo-filtering +geometry=24x300' README.md

**********************************************************************
File "README.md", line 171
Failed example:
    humanize.i18n.activate("pt_BR", path="path/to/my/portuguese/translation/")
Expected:
<gettext.GNUTranslations instance ...>
Got:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/hugo/github/humanize/src/humanize/i18n.py", line 27, in activate
    translation = gettext_module.translation("humanize", path, [locale])
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/gettext.py", line 588, in translation
    raise FileNotFoundError(ENOENT,
FileNotFoundError: [Errno 2] No translation file found for domain: 'humanize'


File README.md, 52/52 test ran in 1.03 seconds
[FAIL] Pass: 51 Fail: 1 Skip: 0

@hugovk hugovk added testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Jun 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          416       416           
=========================================
  Hits           416       416           
Flag Coverage Δ
#GHA_Ubuntu 100.00% <ø> (ø)
#GHA_Windows 100.00% <ø> (ø)
#GHA_macOS 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e4059...8ec52b1. Read the comment docs.

@hugovk hugovk merged commit 64a467d into jmoiron:master Jun 24, 2020
@hugovk hugovk deleted the update-readme branch June 24, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants