Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily comment out to avoid warning during import humanize #243

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Temporarily comment out to avoid warning during import humanize #243

merged 1 commit into from
Nov 29, 2021

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Nov 29, 2021

Temporary fix for #242.

Changes proposed in this pull request:

  • Comment out the warning to avoid warning during import humanize

Before

$ python3 -W error -c 'import humanize'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/humanize/__init__.py", line 17, in <module>
    from humanize.time import (
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/humanize/time.py", line 75, in <module>
    class Unit(Enum, metaclass=_UnitMeta):
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/enum.py", line 215, in __new__
    enum_class._member_names_ = []               # names in definition order
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/enum.py", line 470, in __setattr__
    member_map = cls.__dict__.get('_member_map_', {})
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/humanize/time.py", line 47, in __getattribute__
    warnings.warn(
DeprecationWarning: `Unit` has been deprecated. The enum is still available as the private member `_Unit`.
$ 

After

$  python3 -W error -c 'import humanize'
$ 

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #243 (b7c7952) into master (ab605ba) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   97.08%   97.08%   -0.01%     
==========================================
  Files          10       10              
  Lines         686      685       -1     
==========================================
- Hits          666      665       -1     
  Misses         20       20              
Flag Coverage Δ
GHA_Ubuntu 95.91% <ø> (-0.01%) ⬇️
GHA_Windows 95.62% <ø> (-0.01%) ⬇️
GHA_macOS 95.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/humanize/time.py 96.38% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab605ba...b7c7952. Read the comment docs.

@hugovk hugovk merged commit 429e3d8 into jmoiron:master Nov 29, 2021
@hugovk hugovk deleted the temp-rm-warning branch November 29, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants