helpers: Improve schema detection when creating relative URLs

Fixes gohugoio#11080
jmooring · Jun 10, 2023 · 8fdbfc5 · 8fdbfc5
1 parent 7377970
commit 8fdbfc5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/helpers/url.go b/helpers/url.go
@@ -152,7 +152,13 @@ func (p *PathSpec) getBaseURLRoot(path string) string {
 func (p *PathSpec) RelURL(in string, addLanguage bool) string {
 	baseURL := p.getBaseURLRoot(in)
 	canonifyURLs := p.Cfg.CanonifyURLs()
-	if (!strings.HasPrefix(in, baseURL) && strings.HasPrefix(in, "http")) || strings.HasPrefix(in, "//") {
+
+	url, err := url.Parse(in)
+	if err != nil {
+		return in
+	}
+
+	if (!strings.HasPrefix(in, baseURL) && url.IsAbs()) || strings.HasPrefix(in, "//") {
 		return in
 	}
 

diff --git a/helpers/url_test.go b/helpers/url_test.go
@@ -177,6 +177,10 @@ func doTestRelURL(t *testing.T, defaultInSubDir, addLanguage, multilingual bool,
 		{"/foo/bar", "https://example.org/foo/", false, "MULTI/foo/bar"},
 		{"foo/bar", "https://example.org/foo/", false, "/fooMULTI/foo/bar"},
 
+		// Issue 11080
+		{"mailto:a@b.com", "http://base/", false, "mailto:a@b.com"},
+		{"ftp://b.com/a.txt", "http://base/", false, "ftp://b.com/a.txt"},
+
 		{"/test/foo", "http://base/", false, "MULTI/test/foo"},
 		{"/" + lang + "/test/foo", "http://base/", false, "/" + lang + "/test/foo"},
 		{lang + "/test/foo", "http://base/", false, "/" + lang + "/test/foo"},