-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge last PR #5
Conversation
Generate 2.6.0 minor version at 2024-08-06T10:43:15+02:00
readme typo
Improve regexes for log-file error and warning counts (fixed #797)
Reviewer's Guide by SourceryThis pull request makes changes to the log file processing in mysqltuner.pl and fixes a typo in README.md. The main focus is on improving the log parsing logic to make it more precise and efficient. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmrenouard - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the rationale behind removing the exclusion for 'ERROR_FOR_DIVISION_BY_ZERO' in the log parsing logic? If this was unintentional, consider keeping this exclusion to maintain previous behavior.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
Fix regex patterns for log entry detection in mysqltuner.pl and correct a typo in the README.md file.
Bug Fixes:
Documentation: