Augmented DataAnalyzerResult::to_csv with const string.

jmuehlig · Nov 8, 2024 · 2391cca · 2391cca
1 parent bcc4293
commit 2391cca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/include/perfcpp/analyzer/data.h b/include/perfcpp/analyzer/data.h
@@ -161,9 +161,13 @@ class DataAnalyzerResult
   [[nodiscard]] const std::vector<DataType>& data_types() const noexcept { return _data_types; }
   [[nodiscard]] std::vector<DataType>& data_types() noexcept { return _data_types; }
 
-  [[nodiscard]] std::string to_string() const noexcept;
-  [[nodiscard]] std::string to_json() const noexcept;
-  [[nodiscard]] std::string to_csv(std::string&& data_type_name, char delimiter = ',', bool print_header = true) const noexcept;
+  [[nodiscard]] std::string to_string() const;
+  [[nodiscard]] std::string to_json() const;
+  [[nodiscard]] std::string to_csv(const std::string& data_type_name, char delimiter = ',', bool print_header = true) const;
+  [[nodiscard]] std::string to_csv(std::string&& data_type_name, const char delimiter = ',', const bool print_header = true) const
+  {
+    return to_csv(data_type_name, delimiter, print_header);
+  }
 
 private:
   std::vector<DataType> _data_types;

diff --git a/src/analyzer/data.cpp b/src/analyzer/data.cpp
@@ -93,7 +93,7 @@ perf::analyzer::DataAnalyzer::map(const std::vector<Sample>& samples)
 }
 
 std::string
-perf::analyzer::DataAnalyzerResult::to_string() const noexcept
+perf::analyzer::DataAnalyzerResult::to_string() const
 {
   auto column_headers = std::vector<std::string>{
     "",        "",        "samples",        "loads",           "avg. load lat.", "L1d hits",       "LFB hits",
@@ -188,7 +188,7 @@ perf::analyzer::DataAnalyzerResult::to_string() const noexcept
 }
 
 std::string
-perf::analyzer::DataAnalyzerResult::to_json() const noexcept
+perf::analyzer::DataAnalyzerResult::to_json() const
 {
   auto stream = std::stringstream{};
   stream << "[";
@@ -243,9 +243,9 @@ perf::analyzer::DataAnalyzerResult::to_json() const noexcept
 }
 
 std::string
-perf::analyzer::DataAnalyzerResult::to_csv(std::string&& data_type_name,
+perf::analyzer::DataAnalyzerResult::to_csv(const std::string& data_type_name,
                                            const char delimiter,
-                                           const bool print_header) const noexcept
+                                           const bool print_header) const
 {
   auto stream = std::stringstream{};